1005 CockroachDB - enable array tests #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1005
Using the latest versions of CockroachDB (v24.1.0), and asyncpg (0.29.0), array queries are very slow.
The SQL that Piccolo generates is very simple, so I don't think it's anything to do with Piccolo (also, these queries run fine on Postgres).
Previously, we had a bunch of array tests disabled for CockroachDB. These tests now pass, but they're just very slow. For that reason, we won't run them in the CI.
In the future we'll revisit this when newer versions of CockroachDB and asyncpg are released, or when we support alternative database adapters (e.g.
psycopg3).