-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus request implementation for Android/iOS #2168
Conversation
pichillilorenzo#2168 it is not yet implemented so lets change it until this get the main repo
This is cool fix, thanks. Hope to get it in the main project soon. any updates on this @pichillilorenzo ? |
Hey @yamaha252 I did some test using your code and the problem is almost solved for android devices the focus in the field works, but not able to get the keyboard (tried release and debug versions as well) for iOS is working great, no issue I could detect... |
Just to mention that there is no need to add the
and the class extends the request method will be there anyway and since the implementation has no parameters or return value, we just need to call it. |
I tried the changes and it helps but didn't solved my issues (withtout the requestFocus implementation was not easy to trigger the focus in the right moment) but for Android I commented here #1974 For iOS I used the solution presented here Choices-js/Choices#577 with the combination of all, I was able to get the focus working fine from a search input inside a page loaded using in app webview =) |
adding requestFocus by extending the package works. Will be very helpful to have this merged. Thanks! |
This comment was marked as spam.
This comment was marked as spam.
@all-contributors please add @yamaha252 for code |
I've put up a pull request to add @yamaha252! 🎉 |
Connection with issue(s)
Resolve issue #1974