Update Android Cookie Expiration date format to 24-hour format (HH) #2389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the method for formatting cookie expiration dates in the Android part of the flutter_inappwebview library. Specifically, it changes the time format from hh (12-hour format) to HH (24-hour format).
Changes
Background
It was observed that cookies were correctly saved in the morning, but during late night hours, while iOS stored cookies normally, Android had issues with saving them. After investigation, it was determined that the use of the 12-hour format (hh) was the root cause of this behavior.
Connection with issue(s)
Resolve issue #1778
Connected to #1778
Testing and Review Notes
Please verify the following between 13:00 and 23:00 UTC:
The testing was done using the sample app, where cookies were retrieved and logged for verification. The sample app can be found here:
https://github.com/takuyaaaaaaahaaaaaa/FlutterWebViewSample
Screenshots or Videos
flutter-version:3.24.4
Android: Pixel8 API35 ※simulator
iOS: iPhone16Pro iOS18.1 ※simulator
Android
Before
After
iOS
Before
After
To Do