Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behavior when street name starts with a number #12

Open
dakzilla opened this issue May 17, 2017 · 5 comments
Open

Weird behavior when street name starts with a number #12

dakzilla opened this issue May 17, 2017 · 5 comments
Labels
bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major".

Comments

@dakzilla
Copy link

dakzilla commented May 17, 2017

This example (in a French format) returns an exception: 470 6e Av:
InvalidArgumentException: Address '470 6e Av' could not be splitted into street name and house number

The same example, with an added comma after the house number also doesn't work correctly:

["additionToAddress1"]=> string(3) "470"
["streetName"]=> string(2) "Av"
["houseNumber"]=> string(2) "6e" 

Most of the time, users will not include a comma after the civic number

@dakzilla dakzilla changed the title Weird behavior when street name start with a number Weird behavior when street name starts with a number May 17, 2017
@svenmuennich
Copy link
Member

svenmuennich commented May 18, 2017

Test data:

[
    '470 6e Av',
    [
        'additionToAddress1' => '',
        'streetName' => '6e Av',
        'houseNumber' => '470',
        'houseNumberParts' => [
            'base' => '470',
            'extension' => '', 
        ],
        'additionToAddress2' => ''
    ]
]

@svenmuennich svenmuennich self-assigned this May 18, 2017
@svenmuennich svenmuennich added the bug Issues that describe an unexpected behaviour in an existing functionality. label May 18, 2017
@svenmuennich svenmuennich added the minor "bug" issues that are neither "critical" nor "major". label Mar 1, 2018
@svenmuennich svenmuennich removed their assignment Mar 1, 2018
@virtuance
Copy link

Was this ever fixed @svenmuennich? We're experiencing similar issues.

@svenmuennich
Copy link
Member

This issue is still relevant.

Here's another example coming from #24:

[
    '13 2e Avenue',
    [
        'additionToAddress1' => '',
        'streetName' => '2e Avenue',
        'houseNumber' => '13',
        'houseNumberParts' => [
            'base' => '13',
            'extension' => '', 
        ],
        'additionToAddress2' => ''
    ]
]

@tombaars
Copy link

tombaars commented Oct 4, 2019

Also relevant for Dutch addresses:

[
    '2de Nieuwstadsweg 7 A',
    [
        'additionToAddress1' => '',
        'streetName' => 'Nieuwstadsweg 3 A',
        'houseNumber' => '2de',
        'additionToAddress2' => ''
    ]
]

@villermen
Copy link

And certain American ones:

VIISON\AddressSplitter\AddressSplitter::splitAddress('942 12th Ave');

// VIISON\AddressSplitter\Exceptions\SplittingException: Address '942 12th Ave' could not be splitted into street name and house number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major".
Projects
None yet
Development

No branches or pull requests

4 participants