Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comma (,) stops it from working #20

Open
internetboekhandel opened this issue Mar 8, 2018 · 2 comments
Open

comma (,) stops it from working #20

internetboekhandel opened this issue Mar 8, 2018 · 2 comments
Labels
bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major".

Comments

@internetboekhandel
Copy link

This doesn't work:
residence de la , n°17

This does:
residence de la . n°17

I thought at first the lack of a space before the number was the problem, but with a comma
it fails.
Comma's are not uncommon in addresses, so this is a small problem.

Regars, Theo

@svenmuennich
Copy link
Member

svenmuennich commented Mar 28, 2019

Can you please provide a PHP snippet containing the address string and the expected result, so that we can add it to the unit tests to be able to develop a fix? E.g.:

[
    '3940 Radio Road, Unit 110',
    [
        'additionToAddress1' => '',
        'streetName' => 'Radio Road',
        'houseNumber' => '3940',
        'houseNumberParts' => [
            'base' => '3940',
            'extension' => '', 
        ],
        'additionToAddress2' => 'Unit 110'
    ]
]

@svenmuennich svenmuennich added bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major". labels Mar 28, 2019
@baralogi
Copy link

Hi any suggestion about that, i have address like this

`3940 Radio Road, 110 Unit``

But i got wrong splitt address like that

array:5 [
  "additionToAddress1" => "3940 Radio Road"
  "streetName" => "Unit"
  "houseNumber" => "110"
  "houseNumberParts" => array:2 [
    "base" => "110"
    "extension" => ""
  ]
  "additionToAddress2" => ""
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major".
Projects
None yet
Development

No branches or pull requests

3 participants