Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected Result for address in New Zealand #21

Open
mtrappschuh opened this issue Mar 12, 2018 · 1 comment
Open

Unexpected Result for address in New Zealand #21

mtrappschuh opened this issue Mar 12, 2018 · 1 comment
Labels
bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major".

Comments

@mtrappschuh
Copy link

Given street:
D/5 The Esplanade
(Full Address: D/5 The Esplanade, Eastern Beach, Auckland 2012)

Current result:
array ( 'additionToAddress1' => '', 'streetName' => 'D/', 'houseNumber' => '5', 'houseNumberParts' => array ( 'base' => '5', 'extension' => '', ), 'additionToAddress2' => 'The Promenade', )

Expected result:
array ( 'additionToAddress1' => 'D/', 'streetName' => 'The Promenade', 'houseNumber' => '5', 'houseNumberParts' => array ( 'base' => '5', 'extension' => '', ), 'additionToAddress2' => '', )

The comma in the following line is breaking the expected result:
(?:(?P<A_Addition_to_address_1>.*?),\s*)? # Addition to address 1

@svenmuennich
Copy link
Member

svenmuennich commented Mar 28, 2019

Test data:

[
    'D/5 The Esplanade',
    [
        'additionToAddress1' => 'D/',
        'streetName' => 'The Promenade',
        'houseNumber' => '5',
        'houseNumberParts' => [
            'base' => '5',
            'extension' => '', 
        ],
        'additionToAddress2' => '',
    ]
]

@svenmuennich svenmuennich added bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major". labels Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major".
Projects
None yet
Development

No branches or pull requests

2 participants