Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canadian address with unit fails #32

Open
tareqanwar opened this issue Jan 28, 2020 · 0 comments
Open

Canadian address with unit fails #32

tareqanwar opened this issue Jan 28, 2020 · 0 comments
Labels
bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major".

Comments

@tareqanwar
Copy link

tareqanwar commented Jan 28, 2020

Canadian address format puts unit number(if any) in front of house number.

i.e. 50-100 Street name, 50 - 100 Street name

One possible solution is the bellow code but it doesn't return the apartment number in the additional information. Can you add a fix on next release?

private static $generalNumberPrefixes = [
        // English
        'No [.:]?',
        'Nos ([.:]|\s)',
        'Number \s',

        //Canada
        '^[0-9]*\s?\-\s?',

        // German
        'Nr [.:]?',
        'Nummer \s',

        // Other
        '№ [.:]?',
        'Nº [.:]?',
        'n° [.:]?'
    ];
@svenmuennich svenmuennich added bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major". labels Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major".
Projects
None yet
Development

No branches or pull requests

2 participants