Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deribit updates #471

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Deribit updates #471

wants to merge 11 commits into from

Conversation

goodboy
Copy link
Contributor

@goodboy goodboy commented Feb 28, 2023

Various updates since deribit was last authored / tested 😂 :

  • add deribit to our default backend scan list in piker.brokers.__brokers__: list[str]
  • fixes for new msgspec version namely ensuring default spec-ced fields are placed after fields with non-defaults.
  • API tweak to match new kwarg name in open_jsonrpc_session(): dtype ->
    response_type=JSONRPCResult
  • fix the Callable yielded from open_history_client() to accept the timeframe: float arg now required for multi-sample rate queries.

ToDo for this to land

  • support and/or fix 1s OHLC chart sampling
    • tread step size is borked when overlayed with btcusdt.binance? think it's fixed now after adjusting the history loader in bullet below?
    • adjust the open_history_client() routine(s) to appropriately block on 1s history queries fixed in 47a4da9
  • do a once over lint with at least flake8

@goodboy goodboy requested review from guilledk and esmegl February 28, 2023 05:31
@goodboy
Copy link
Contributor Author

goodboy commented Feb 28, 2023

I'm going to do a bit more linting and testing of this code to see if we can get it up to snuff with the latest paper trading stuff in #462 as well 🏄🏼

@goodboy goodboy marked this pull request as ready for review March 3, 2023 23:32
@goodboy
Copy link
Contributor Author

goodboy commented Apr 14, 2023

@guilledk where we at on this one carnal?

I kinda wanna play with some opts feeds this weekend 🏄🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants