Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove promise support check from tests #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cleanup: remove promise support check from tests #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions test/param.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ const shouldNotHitHandle = utils.shouldNotHitHandle
const createServer = utils.createServer
const request = utils.request

const describePromises = global.Promise ? describe : describe.skip

describe('Router', function () {
describe('.param(name, fn)', function () {
it('should reject missing name', function () {
Expand Down Expand Up @@ -264,7 +262,7 @@ describe('Router', function () {
.expect(500, /Error: boom/, done)
})

describePromises('promise support', function () {
describe('promise support', function () {
it('should pass rejected promise value', function (done) {
const router = new Router()
const server = createServer(router)
Expand Down
4 changes: 1 addition & 3 deletions test/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ const shouldNotHaveBody = utils.shouldNotHaveBody
const shouldNotHitHandle = utils.shouldNotHitHandle
const methods = utils.methods

const describePromises = global.Promise ? describe : describe.skip

describe('Router', function () {
describe('.route(path)', function () {
it('should return a new route', function () {
Expand Down Expand Up @@ -542,7 +540,7 @@ describe('Router', function () {
})
})

describePromises('promise support', function () {
describe('promise support', function () {
it('should pass rejected promise value', function (done) {
const router = new Router()
const route = router.route('/foo')
Expand Down
4 changes: 1 addition & 3 deletions test/router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ const shouldNotHaveBody = utils.shouldNotHaveBody
const shouldNotHitHandle = utils.shouldNotHitHandle
const methods = utils.methods

const describePromises = global.Promise ? describe : describe.skip

describe('Router', function () {
it('should return a function', function () {
assert.equal(typeof Router(), 'function')
Expand Down Expand Up @@ -770,7 +768,7 @@ describe('Router', function () {
})
})

describePromises('promise support', function () {
describe('promise support', function () {
it('should pass rejected promise value', function (done) {
const router = new Router()
const server = createServer(router)
Expand Down
Loading