Update a non-existing filter shows an error message.

pimcore · Mar 28, 2023 · 220a920 · 220a920
1 parent 9b9d1ac
commit 220a920
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/Controller/Admin/Customers/FilterDefinitionController.php b/src/Controller/Admin/Customers/FilterDefinitionController.php
@@ -115,6 +115,15 @@ public function updateAction(Request $request, CustomerViewInterface $customerVi
     {
         // fetch object parameters from request
         $filterDefinition = $this->getFilterDefinitionFromRequest($request, true, true);
+
+        // check if a filter is selected
+        if (empty($filterDefinition)) {
+            // add error message for missing filter
+            $errors[] = $customerView->translate('cmf_filter_definition_errors_filter_missing');
+
+            return $this->getRedirectToFilter(0, $errors);
+        }
+
         // check mandatory FilterDefinition name
         if (empty($filterDefinition->getName())) {
             // add error message for missing filter name

diff --git a/src/Resources/translations/admin.en.yml b/src/Resources/translations/admin.en.yml
@@ -116,6 +116,7 @@ cmf_filter_definition_errors_access: "Not allowed to access filter."
 cmf_filter_definition_errors_change: "Not allowed to change filter."
 cmf_filter_definition_errors_deletion_failed: "Deletion of filter failed. (%s)"
 cmf_filter_definition_errors_name_missing: "Please provide a filter name."
+cmf_filter_definition_errors_filter_missing: "Please select a filter."
 cmf_filter_definition_errors_save_failed: "Save of filter failed. (%s)"
 cmf_filter_definition_errors_share_failed: "Sharing filter failed. (%s)"