Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Request::get with explicit input sources #543

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Replace Request::get with explicit input sources #543

merged 1 commit into from
Nov 28, 2024

Conversation

kingjia90
Copy link
Contributor

Resolves #408

@kingjia90 kingjia90 added this to the 4.2.0 milestone Nov 27, 2024
@kingjia90 kingjia90 marked this pull request as ready for review November 27, 2024 12:27
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mattamon
mattamon approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kingjia90 kingjia90 merged commit 4ec3748 into 4.x Nov 28, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
@kingjia90 kingjia90 deleted the replace-request-get branch November 28, 2024 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattamon mattamon mattamon approved these changes

Assignees

@mattamon mattamon

Labels
Improvement Pimcore:ToDo
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

Replace Request::get with explicit input sources
2 participants
@kingjia90 @mattamon