Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ikhal doesn't save changes in start or end times if you exit the widget with Page Down #1345

Closed
Pi2048 opened this issue Apr 20, 2024 · 2 comments

Comments

@Pi2048
Copy link

Pi2048 commented Apr 20, 2024

Describe the bug
If I open an event for editing in ikhal, and I change the start or end time, this change is sometimes not saved. This occurs if I exit the widget for the start or end time by using Page Down instead of the arrow keys.

If applicable: Stack Trace
n/a

To Reproduce
Steps to reproduce the behavior:

These are the steps for the From: time, but the bug also applies to the To: time.

  • Start ikhal
  • Move the cursor to an existing event with a start and end time (i.e. not an all-day event) and press enter to view details.
  • Press enter again to open the event editor
  • Use the arrow keys to navigate to the From: time field.
  • Change its value slightly, e.g. change 18:10 to 18:12
  • Navigate away from the field, but use Page Down instead of the arrow keys. The cursor ends up on the Export button.
  • Press the up arrow key once to land on the Save button.
  • Press enter to press the Save button.

Expected behavior
I expected the change I made to the From: time to be saved and displayed in the calendar overview. Instead, the change I made is silently dropped.

Screenshots
If applicable, add screenshots to help explain your problem.

OS, version, khal version and how you installed it:

  • The output of khal --version: khal, version 0.11.3
  • Installation method: PyPi
  • python version: Python 3.10
  • OS: Ubuntu 22.04
  • Your khal config file: I use a minimal config file with two calendars. The only fields that are relevant to this bug are:
[locale]

timeformat="%H:%M"
  • The versions of your other python packages [e.g. the output of pip freeze]
    n/a

Additional context
Add any other context about the problem here. Especially, if the issue came up when reading an .ics file, please provide the content of that file (anonymize if needed).

@Pi2048
Copy link
Author

Pi2048 commented Apr 21, 2024

This is possibly a duplicate of #1274

Pi2048 pushed a commit to Pi2048/khal that referenced this issue Apr 21, 2024
Add page up and page down to keys that trigger an event update
@geier
Copy link
Member

geier commented Apr 23, 2024

should be fixed with #1346

@geier geier closed this as completed Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants