-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoticeSetting.medium should be IntegerField instead of CharField #21
Comments
@ptone thanks for this, somehow i had missed it and just not logged onto Freenode and got your message (I use a bouncer). I'll look into this over the next week. |
the same thing... |
+1 On this. It's quite simple fix, i can send a PR if interested. |
I would rather change the load_backends function to not use integer ids to represent the medium. If you rearrange the backends, this would break user setttings. I propose we use either a required Thoughts? EDIT: actually, can we just use the default_backends = [
("email", "notification.backends.email.EmailBackend"),
] |
When the model is validated, the to_python of the charfield returns the value '0' which is not a valid choice key.
This trips up django.db.models.fields.Field.validate and causes any modelform for this model to fail submission (including in the admin).
see also:
https://code.djangoproject.com/ticket/20800
for why this took me more than a second to debug
The text was updated successfully, but these errors were encountered: