Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use API to geocode searches rather than react-geocode #447

Open
RyanTG opened this issue Jun 16, 2022 · 1 comment
Open

Use API to geocode searches rather than react-geocode #447

RyanTG opened this issue Jun 16, 2022 · 1 comment

Comments

@RyanTG
Copy link
Collaborator

RyanTG commented Jun 16, 2022

On the website, we recently improved geocoding results by including nominatim as a fallback. However, this isn't possible with the react-geocode.

Instead of using that package, let's use our API for geocoding searches.

It seems like we would have to continue using react-geocode for Events.

@RyanTG RyanTG changed the title Fallback geocoder? Use API to geocode searches rather than react-geocode Jun 16, 2022
@RyanTG RyanTG added the 5.2.13 label Oct 28, 2022
@RyanTG RyanTG added 5.2.15 and removed 5.2.14 labels Nov 22, 2022
@RyanTG RyanTG added 5.2.16 and removed 5.2.15 labels Dec 6, 2022
@RyanTG RyanTG added 5.2.17 and removed 5.2.16 labels Jan 4, 2023
@RyanTG RyanTG added 5.2.20 and removed 5.2.18 labels Jan 17, 2023
@RyanTG RyanTG added 5.2.21 and removed 5.2.20 labels Mar 9, 2023
@RyanTG RyanTG removed the 5.2.21 label May 5, 2023
@RyanTG
Copy link
Collaborator Author

RyanTG commented Oct 24, 2024

Alternative: use expo-location for geocoding.

I think for Search.js it would be a geocode (converting address into lat/lon) and for Events.js it would be reversegeocode (converting lat/lon into formattedAddress... although I now see that formattedAddress is Android-only, so maybe this wouldn't work for us).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant