-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand localization of distance/user preference across the app #535
Comments
Added a draft PR. #536 |
Yeah, I think we just didn't bother with adjusting the distance unit in this case because it didn't seem terribly important. Beth can probably refresh my memory, though. So I guess the options are:
|
This PR is open but incomplete. Are you planning to complete it? |
Yes I can promote this from draft. I'll be able to submit in the next few days. I haven't loaded the app locally in a while, I'll likely need a new build. Is there a place to get that from? @RyanTG |
I'll make new dev builds. Can you shoot an email to admin@pinballmap and then I'll send you the link to it? |
sent. |
Found that the events page text when no events were returned was not toggling km/mi but the buttons to change distance do toggle km/mi. Looking across the app, the activities page does not toggle km/mi.
The text was updated successfully, but these errors were encountered: