Show warning when both logged in and using api key

Author: jhamon

internal/pkg/cli/command/logout/logout.go

@@ -4,8 +4,7 @@ import (
 	"github.com/pinecone-io/cli/internal/pkg/utils/configuration/secrets"
 	"github.com/pinecone-io/cli/internal/pkg/utils/configuration/state"
 	"github.com/pinecone-io/cli/internal/pkg/utils/help"
-	"github.com/pinecone-io/cli/internal/pkg/utils/pcio"
-	"github.com/pinecone-io/cli/internal/pkg/utils/style"
+	"github.com/pinecone-io/cli/internal/pkg/utils/msg"
 	"github.com/spf13/cobra"
 )
 
@@ -16,10 +15,10 @@ func NewLogoutCmd() *cobra.Command {
 		GroupID: help.GROUP_START.ID,
 		Run: func(cmd *cobra.Command, args []string) {
 			secrets.ConfigFile.Clear()
-			pcio.Println(style.SuccessMsg("Secrets cleared."))
+			msg.SuccessMsg("API keys and user access tokens cleared.")
 
 			state.ConfigFile.Clear()
-			pcio.Println(style.SuccessMsg("State cleared."))
+			msg.SuccessMsg("State cleared.")
 		},
 	}
 

internal/pkg/cli/command/target/target.go

@@ -227,7 +227,6 @@ func postLoginSetTargetOrg(orgsResponse *dashboard.OrganizationsResponse) string
 		orgName = orgsResponse.Organizations[0].Name
 		log.Info().Msgf("Only 1 org present so target org set to %s", orgName)
 	} else {
-		pcio.Println()
 		pcio.Println("Many API operations take place in the context of a specific org and project.")
 		pcio.Println(pcio.Sprintf("This CLI maintains a piece of state called the %s so it knows which \n", style.Emphasis("target")) +
 			"organization and project to use when calling the API on your behalf.")

internal/pkg/utils/sdk/client.go

@@ -44,16 +44,19 @@ func newClientForUserFromTarget() *pinecone.Client {
 		Msg("Loading target context")
 
 	apiKey := secrets.ApiKey.Get()
+	oauth2Token := secrets.OAuth2Token.Get()
 
 	if apiKey != "" {
+		if oauth2Token.AccessToken != "" {
+			msg.WarnMsg("You are currently logged in and also have an API key set in your configuration. The API key (which is linked to a specific project) will be used in preference to any user authentication and target context that may be present.\n")
+		}
+
 		log.Debug().Msg("Creating client for machine using stored API key")
 		return NewClientForMachine(apiKey)
 	}
 
 	log.Debug().Msg("No API key is stored in configuration, so attempting to create a client using user access token")
 
-	oauth2Token := secrets.OAuth2Token.Get()
-
 	if oauth2Token.AccessToken == "" {
 		msg.FailMsg("Please set an API key with %s or login with %s before attempting this operation.", style.Code("pinecone config set-api-key"), style.Code("pinecone login"))
 		exit.ErrorMsg("User is not logged in")