From 5d5487c112439c2b89570379a8f47a6363dbec39 Mon Sep 17 00:00:00 2001 From: kenjis Date: Mon, 23 Oct 2023 06:44:26 +0900 Subject: [PATCH] Revert "docs: fix event points descriptions" --- user_guide_src/source/changelogs/v4.4.2.rst | 2 -- user_guide_src/source/extending/events.rst | 9 ++------- user_guide_src/source/installation/upgrade_4xx.rst | 6 ------ 3 files changed, 2 insertions(+), 15 deletions(-) diff --git a/user_guide_src/source/changelogs/v4.4.2.rst b/user_guide_src/source/changelogs/v4.4.2.rst index 12fad5ed55df..eb146ef07c0c 100644 --- a/user_guide_src/source/changelogs/v4.4.2.rst +++ b/user_guide_src/source/changelogs/v4.4.2.rst @@ -44,8 +44,6 @@ Bugs Fixed - **Forge:** Fixed a bug where adding a Primary Key to an existing table was ignored if there were no other Keys added too. - **Routing:** Fixed a bug that ``spark routes`` may show incorrect route names. -- **UserGuide:** Fixed the descriptions for ``pre_system`` and ``post_system`` - in :ref:`event-points`. See the repo's `CHANGELOG.md `_ diff --git a/user_guide_src/source/extending/events.rst b/user_guide_src/source/extending/events.rst index 7891249cdcf6..74fe34b4fe70 100644 --- a/user_guide_src/source/extending/events.rst +++ b/user_guide_src/source/extending/events.rst @@ -82,19 +82,14 @@ You can stop simulation by passing false: .. literalinclude:: events/008.php -.. _event-points: - Event Points ============ The following is a list of available event points within the CodeIgniter core code: -* **pre_system** Called early during system execution. The URI, Request, and - Response have been instantiated, but page cache checking, routing, and execution - of "before" controller filters have not yet occurred. +* **pre_system** Called very early during system execution. Only the benchmark and events class have been loaded at this point. No routing or other processes have happened. * **post_controller_constructor** Called immediately after your controller is instantiated, but prior to any method calls happening. -* **post_system** Called right before the final rendered page is sent to the browser, - at the end of system execution, after the execution of "after" controller filters. +* **post_system** Called after the final rendered page is sent to the browser, at the end of system execution after the finalized data is sent to the browser. * **email** Called after an email sent successfully from ``CodeIgniter\Email\Email``. Receives an array of the ``Email`` class's properties as a parameter. * **DBQuery** Called after a database query whether successful or not. Receives the ``Query`` object. * **migrate** Called after a successful migration call to ``latest()`` or ``regress()``. Receives the current properties of ``MigrationRunner`` as well as the name of the method. diff --git a/user_guide_src/source/installation/upgrade_4xx.rst b/user_guide_src/source/installation/upgrade_4xx.rst index bf7ba85fece6..ae645d26c1a9 100644 --- a/user_guide_src/source/installation/upgrade_4xx.rst +++ b/user_guide_src/source/installation/upgrade_4xx.rst @@ -153,12 +153,6 @@ Hooks - Instead of CI3's ``$hook['post_controller_constructor']`` you now use ``Events::on('post_controller_constructor', ['MyClass', 'MyFunction']);``, with the namespace ``CodeIgniter\Events\Events;``. - Events are always enabled, and are available globally. -- The hook point ``pre_controller`` and ``post_controller`` have been removed. - Use :doc:`../incoming/filters` instead. -- The hook point ``display_override`` and ``cache_override`` have been removed. - Because the base methods have been removed. -- The hook point ``post_system`` has moved just before sending the final rendered - page. Extending the Framework =======================