Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partition: set AddRecordOpt.isUpdate = true when update partition records #57590

Merged
merged 2 commits into from
Nov 22, 2024
Merged

partition: set AddRecordOpt.isUpdate = true when update partition records #57590

merged 2 commits into from
Nov 22, 2024
+27 −3

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Nov 21, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #57588

Problem Summary:

Didn't set isUpdate = true before, so it will use the last value in datum as _tidb_rowid which caused primary key duplicate.

If we don't do this during add columns, len(r) == len(cols) always equal to true, so it's safe.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2024
@tiprow tiprow
Copy link

tiprow bot commented Nov 21, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9283%. Comparing base (4442d49) to head (71a3663).
Report is 22 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #57590        +/-   ##
================================================
+ Coverage   72.8834%   74.9283%   +2.0449%     
================================================
  Files          1676       1721        +45     
  Lines        463577     476802     +13225     
================================================
+ Hits         337871     357260     +19389     
+ Misses       104863      97345      -7518     
- Partials      20843      22197      +1354
Flag Coverage Δ
integration 49.5274% <100.0000%> (?)
unit 72.3945% <100.0000%> (+0.1137%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 60.9551% <ø> (+15.5834%) ⬆️
---- 🚨 Try these New Features:

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2024
@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Nov 21, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mjonss
mjonss approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 21, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 22, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-21 11:32:54.465597362 +0000 UTC m=+117762.085251898: ☑️ agreed by mjonss.
  • 2024-11-22 01:48:56.354771128 +0000 UTC m=+169123.974425644: ☑️ agreed by tangenta.

@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Nov 22, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Nov 22, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Nov 22, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit bd20f66 into pingcap:master Nov 22, 2024
27 checks passed
@Defined2014 Defined2014 added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 22, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57622.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@mjonss mjonss mjonss approved these changes

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report unexpected duplicate when update partition tables during add column.
4 participants
@Defined2014 @ti-chi-bot @mjonss @tangenta