Skip to content

Commit

Permalink
Redact query arguments in dm log (#11783)
Browse files Browse the repository at this point in the history
close #11489
  • Loading branch information
db-will authored Nov 21, 2024
1 parent f1f286a commit f4dcfe4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dm/syncer/dbconn/db.go
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ func (conn *DBConn) retryableFn(tctx *tcontext.Context, queries, args any) func(
if err != nil {
tctx.L().Error("reset connection failed", zap.Int("retry", retryTime),
zap.String("queries", utils.TruncateInterface(queries, -1)),
zap.String("arguments", utils.TruncateInterface(args, -1)),
log.ZapRedactString("arguments", utils.TruncateInterface(args, -1)),
log.ShortError(err))
return false
}
Expand All @@ -257,7 +257,7 @@ func (conn *DBConn) retryableFn(tctx *tcontext.Context, queries, args any) func(
if dbutil.IsRetryableError(err) {
tctx.L().Warn("execute statements", zap.Int("retry", retryTime),
zap.String("queries", utils.TruncateInterface(queries, -1)),
zap.String("arguments", utils.TruncateInterface(args, -1)),
log.ZapRedactString("arguments", utils.TruncateInterface(args, -1)),
log.ShortError(err))
return true
}
Expand Down

0 comments on commit f4dcfe4

Please sign in to comment.