Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixometer.clear_counter/1 is supposed to use configured Formatter #117

Open
pmenhart opened this issue Dec 22, 2018 · 2 comments
Open

Elixometer.clear_counter/1 is supposed to use configured Formatter #117

pmenhart opened this issue Dec 22, 2018 · 2 comments
Labels

Comments

@pmenhart
Copy link

A default formatter Elixometer.Utils is called instead of a configured one:

clear_counter(format(:counters, metric_name))

To fix, Elixometer.Utils should either expose the configured formatter, or implement clear_counter/1.
Exposing formatter is preferable, because there are often situations where an application may need to translate metric names between "Elixometer view" and "exometer view".

@jparise
Copy link
Collaborator

jparise commented Dec 22, 2018

Is this related to #114 (comment)?

@jparise jparise added the bug label Dec 22, 2018
@pmenhart
Copy link
Author

Yes, this is the same issue as you reported in the comment. I didn't notice it, because #114 is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants