Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Campaign Lifetime Budget Updates Does Not Send List #139

Closed
jena-cameron opened this issue Oct 9, 2024 · 1 comment
Closed

BUG - Campaign Lifetime Budget Updates Does Not Send List #139

jena-cameron opened this issue Oct 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jena-cameron
Copy link

Describe the bug

The Lifetime Budget update fails because it does not wrap the CampaignUpdateRequest in a list like the Daily Budget update.

If a Life time budget update is attempted we receive the following error:
Invalid type for variable 'campaign_update_request'. Required value type is list and passed type was CampaignUpdateRequest at ['campaign_update_request']

To Reproduce

Steps to reproduce the behavior:

  1. The model/class with an issue is pinterest/ads/Campaigns.py
  2. The function with an issue is set_lifetime_budget(self, new_spend_cap:int)
  3. The arguments passed to the model/function are any positive integer value
  4. The error thrown is 'Invalid type for variable 'campaign_update_request'. Required value type is list and passed type was CampaignUpdateRequest at ['campaign_update_request']

Expected behavior

I would expect the CampaignUpdateRequest object to be wrapped in a list object like the set_daily_budget function in the same class.

Screenshots

Screenshot 2024-10-09 at 10 48 47 AM

Additional Details (please complete the following information):

  • OS and Version: MacOS and Windows
  • SDK Version [all versions]

Additional Context
n/a

@jena-cameron jena-cameron added the bug Something isn't working label Oct 9, 2024
@t20
Copy link
Contributor

t20 commented Oct 30, 2024

Fixed in #140
Made a new release. Available in pinterest-api-sdk==0.2.4

@t20 t20 closed this as completed Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants