fix: added new "preformatted" transform option to properly display newlines in query results #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lines (pinterest#157) * fix: added new transform format list to display show create results properly * fix: remove pre component and add new column type multiline * fix: changed transformer name to preformatted Co-authored-by: jvalvo <[email protected]>
czgu
reviewed
Sep 15, 2023
| priority: 0, | ||
| auto: true, | ||
| transform: (v: string): React.ReactNode => ( | ||
| <div className={'preformatted'}>{v}</div> |
There was a problem hiding this comment.
is there associated css with preformatted?
also can you include a screenshot of what is before vs after?
There was a problem hiding this comment.
I updated the PR with this information. Thank you!
|
lgtm. @czgu do you have any other concerns? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes a new "multiline" column type which is assigned when a string contains newlines (\n). The initial use case for this feature was to be able to display the results of a "show create view" or "show create table" query properly without expanding the query results.
Before:
After:
"preformatted" CSS:
https://github.com/pinterest/querybook/blob/master/querybook/webapp/stylesheets/_utilities.scss
It does the same thing as expanding the cell, but it does it automatically for results with newlines without requiring the user to select the option