Bugfix NPE that occurs during version upgrade with empty/default resource isolation group #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
When upgrading for the first time to use resource isolation groups, there's an issue where the TabletComputeNodeMapper doesn't know about the default/empty resource isolation group, due to the way that the
modifyComputeNode
function worked.What I'm doing:
modifyComputeNode
is idempotent, so we'll let it run regardless of whether the old and new resource isolation groups match.Fixes #issue https://jira.pinadmin.com/browse/RTA-6269
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: