Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix NPE that occurs during version upgrade with empty/default resource isolation group #14

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

ctbrennan
Copy link

@ctbrennan ctbrennan commented Oct 15, 2024

Why I'm doing:

When upgrading for the first time to use resource isolation groups, there's an issue where the TabletComputeNodeMapper doesn't know about the default/empty resource isolation group, due to the way that the modifyComputeNode function worked.

What I'm doing:

  • modifyComputeNode is idempotent, so we'll let it run regardless of whether the old and new resource isolation groups match.
  • Also, improve situations where a resource isolation group has no CN, by returning empty collections instead of null, which reduces chances for NPE.
  • Also expand parsing of resource isolation group in statements to allow unsetting/setting-to-empty the resource isolation group.

Fixes #issue https://jira.pinadmin.com/browse/RTA-6269

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • [] Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@ctbrennan ctbrennan changed the title bugfix for issue during upgrade Bugfix NPE that occurs during version upgrade with empty/default resource isolation group Oct 16, 2024
@ctbrennan ctbrennan marked this pull request as ready for review October 16, 2024 18:24
@ctbrennan ctbrennan merged commit dbccef4 into pinterest-integration-3.3 Oct 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants