Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Y/Y 364 days to delta tooltip #35

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Add Y/Y 364 days to delta tooltip #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions superset-frontend/plugins/plugin-chart-echarts/src/pinterest-utils/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ export const TIME_OFFSET_BY_COLUMN = {
[DeltaTableColumn.DayOverDay]: 1,
[DeltaTableColumn.WeekOverWeek]: 7,
[DeltaTableColumn.MonthOverMonth]: 28,
[DeltaTableColumn.YearOverYear]: 365,
[DeltaTableColumn.YearOverYear364]: 364,
[DeltaTableColumn.YearOverYear365]: 365,
} as Record<DeltaTableColumn, number>;

export const DELTA_TABLE_COLUMNS = [
Expand All @@ -13,14 +14,16 @@ export const DELTA_TABLE_COLUMNS = [
DeltaTableColumn.DayOverDay,
DeltaTableColumn.WeekOverWeek,
DeltaTableColumn.MonthOverMonth,
DeltaTableColumn.YearOverYear,
DeltaTableColumn.YearOverYear364,
DeltaTableColumn.YearOverYear365,
];

export const PERCENT_CHANGE_COLUMNS = [
DeltaTableColumn.DayOverDay,
DeltaTableColumn.WeekOverWeek,
DeltaTableColumn.MonthOverMonth,
DeltaTableColumn.YearOverYear,
DeltaTableColumn.YearOverYear364,
DeltaTableColumn.YearOverYear365,
];

export const MILLISECONDS_IN_DAY = 1000 * 60 * 60 * 24;
Expand All @@ -36,6 +39,7 @@ export const PINTEREST_DEFAULT_FORM_DATA = {
DeltaTableColumn.DayOverDay,
DeltaTableColumn.WeekOverWeek,
DeltaTableColumn.MonthOverMonth,
DeltaTableColumn.YearOverYear,
DeltaTableColumn.YearOverYear364,
DeltaTableColumn.YearOverYear365,
],
};
3 changes: 2 additions & 1 deletion superset-frontend/plugins/plugin-chart-echarts/src/pinterest-utils/controls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ export const pinterestCustomConfig: ControlSetRow[] = [
DeltaTableColumn.DayOverDay,
DeltaTableColumn.WeekOverWeek,
DeltaTableColumn.MonthOverMonth,
DeltaTableColumn.YearOverYear,
DeltaTableColumn.YearOverYear364,
DeltaTableColumn.YearOverYear365,
]),
default: PINTEREST_DEFAULT_FORM_DATA.pinterestDeltaTableColumns,
renderTrigger: true,
Expand Down
9 changes: 4 additions & 5 deletions superset-frontend/plugins/plugin-chart-echarts/src/pinterest-utils/tooltip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,10 @@ export const getDateByTimeDelta = {
[DeltaTableColumn.DayOverDay]: (date: Date) => getPreviousDate(date, 1),
[DeltaTableColumn.WeekOverWeek]: (date: Date) => getPreviousDate(date, 7),
[DeltaTableColumn.MonthOverMonth]: (date: Date) => getPreviousDate(date, 28),
[DeltaTableColumn.YearOverYear]: (date: Date) => {
const previousDate = new Date(date);
previousDate.setFullYear(date.getFullYear() - 1);
return previousDate;
},
[DeltaTableColumn.YearOverYear364]: (date: Date) =>
getPreviousDate(date, 364),
[DeltaTableColumn.YearOverYear365]: (date: Date) =>
getPreviousDate(date, 365),
} as Record<DeltaTableColumn, (date: Date) => Date>;

type DeltaTableTooltipColumn = {
Expand Down
3 changes: 2 additions & 1 deletion superset-frontend/plugins/plugin-chart-echarts/src/pinterest-utils/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ export enum DeltaTableColumn {
DayOverDay = 'D/D',
WeekOverWeek = 'W/W',
MonthOverMonth = 'M/M',
YearOverYear = 'Y/Y',
YearOverYear364 = 'Y/Y (364 days)',
YearOverYear365 = 'Y/Y (365 days)',
}
export enum DeltaDirection {
Up = 'Up',
Expand Down
Loading