Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a functional testing module with tests for all methods #1294

Open
DavAug opened this issue Feb 16, 2021 · 5 comments · May be fixed by #1295
Open

Create a functional testing module with tests for all methods #1294

DavAug opened this issue Feb 16, 2021 · 5 comments · May be fixed by #1295
Labels
testing

Comments

@DavAug
Copy link
Member

DavAug commented Feb 16, 2021

The module will contain the functional tests in pints, e.g. one file for each sampler and each optimiser. We start with the HarrioBardenerACMC.
@DavAug
Copy link
Member Author

DavAug commented Feb 16, 2021 •
edited
Loading

A class should contain a method that returns the results in dict format. Until the new diagnostics module is implemented, we could start with

  • Gaussian shape kld
  • mean ESS

DavAug added a commit that referenced this issue Feb 16, 2021
@DavAug
#1294 functional test HaarioBardenet
23a69ac
@DavAug DavAug linked a pull request Feb 16, 2021 that will close this issue
Draft
DavAug added a commit that referenced this issue Feb 16, 2021
@DavAug
#1294 exclude functional tests from coverage rep
4e5bef1
DavAug added a commit that referenced this issue Feb 16, 2021
@DavAug
#1294 add copyright notice
6e36010
DavAug added a commit that referenced this issue Feb 16, 2021
@DavAug
#1294 flake8
5986250
fcooper8472 added a commit that referenced this issue Mar 16, 2021
@fcooper8472
#1294 update structure
fdbf30d 
Defer creation of toy problem to class; define function for specific method
fcooper8472 added a commit that referenced this issue Mar 16, 2021
@fcooper8472
#1294 allow setting of hyper parameters
1225905
@fcooper8472
Copy link
Member

@MichaelClerx @ben18785 does this look about right?
1225905

@ben18785
Copy link
Collaborator

ben18785 commented Mar 16, 2021 via email

@MichaelClerx
Copy link
Member

MichaelClerx commented Mar 16, 2021 •
edited
Loading

Perfect! I'm thinking method_hyper_parameters could eventually be a dict rather than an array, but that's a separate issue

@MichaelClerx MichaelClerx changed the title Create a functional testing module with a module for the HarrioBardenerACMC tests Create a functional testing module with tests for all methods Aug 11, 2021
@MichaelClerx
Copy link
Member

MichaelClerx commented Jun 8, 2022 •
edited
Loading

Related, for optimisers:

@MichaelClerx MichaelClerx mentioned this issue Nov 7, 2023
Open
11 tasks
@MichaelClerx MichaelClerx mentioned this issue Dec 12, 2023
Merged
@github-project-automation github-project-automation bot moved this to To do in Testing Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
Testing
Status: To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change-point tests pints-team/pints
4 participants
@MichaelClerx @fcooper8472 @ben18785 @DavAug