From cd52e6b52de3da14e11250a3f202c5eefe057c99 Mon Sep 17 00:00:00 2001 From: Kevin Wang Date: Fri, 25 Oct 2024 17:23:15 -0400 Subject: [PATCH] Export min and max delay in header extension Exports the min and max delay attributes. --- playoutdelayextension.go | 14 +++++++------- playoutdelayextension_test.go | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/playoutdelayextension.go b/playoutdelayextension.go index 3882731..e8b9829 100644 --- a/playoutdelayextension.go +++ b/playoutdelayextension.go @@ -23,19 +23,19 @@ var errPlayoutDelayInvalidValue = errors.New("invalid playout delay value") // | ID | len=2 | MIN delay | MAX delay | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ type PlayoutDelayExtension struct { - minDelay, maxDelay uint16 + MinDelay, MaxDelay uint16 } // Marshal serializes the members to buffer func (p PlayoutDelayExtension) Marshal() ([]byte, error) { - if p.minDelay > playoutDelayMaxValue || p.maxDelay > playoutDelayMaxValue { + if p.MinDelay > playoutDelayMaxValue || p.MaxDelay > playoutDelayMaxValue { return nil, errPlayoutDelayInvalidValue } return []byte{ - byte(p.minDelay >> 4), - byte(p.minDelay<<4) | byte(p.maxDelay>>8), - byte(p.maxDelay), + byte(p.MinDelay >> 4), + byte(p.MinDelay<<4) | byte(p.MaxDelay>>8), + byte(p.MaxDelay), }, nil } @@ -44,7 +44,7 @@ func (p *PlayoutDelayExtension) Unmarshal(rawData []byte) error { if len(rawData) < playoutDelayExtensionSize { return errTooSmall } - p.minDelay = binary.BigEndian.Uint16(rawData[0:2]) >> 4 - p.maxDelay = binary.BigEndian.Uint16(rawData[1:3]) & 0x0FFF + p.MinDelay = binary.BigEndian.Uint16(rawData[0:2]) >> 4 + p.MaxDelay = binary.BigEndian.Uint16(rawData[1:3]) & 0x0FFF return nil } diff --git a/playoutdelayextension_test.go b/playoutdelayextension_test.go index 8810466..b08cbdb 100644 --- a/playoutdelayextension_test.go +++ b/playoutdelayextension_test.go @@ -20,7 +20,7 @@ func TestPlayoutDelayExtensionTooSmall(t *testing.T) { } func TestPlayoutDelayExtensionTooLarge(t *testing.T) { - t1 := PlayoutDelayExtension{minDelay: 1 << 12, maxDelay: 1 << 12} + t1 := PlayoutDelayExtension{MinDelay: 1 << 12, MaxDelay: 1 << 12} if _, err := t1.Marshal(); !errors.Is(err, errPlayoutDelayInvalidValue) { t.Fatal("err != errPlayoutDelayInvalidValue") @@ -39,7 +39,7 @@ func TestPlayoutDelayExtension(t *testing.T) { } t2 := PlayoutDelayExtension{ - minDelay: 1 << 4, maxDelay: 1 << 8, + MinDelay: 1 << 4, MaxDelay: 1 << 8, } if t1 != t2 { @@ -64,7 +64,7 @@ func TestPlayoutDelayExtensionExtraBytes(t *testing.T) { } t2 := PlayoutDelayExtension{ - minDelay: 1 << 4, maxDelay: 1 << 8, + MinDelay: 1 << 4, MaxDelay: 1 << 8, } if t1 != t2 {