Add ARAM support

[sudravirodhin]

Hi Felipe!

Mucho gusto.

u.gg Integration works great for default roles!

Gonna make some assumptions and suggest ideas for how to improve it.

Assuming you get the current role from the League Client, you can use that and query u.gg with a specific URL. Example: Zyra locks in as Jungle and you query https://u.gg/lol/champions/zyra/build/?role=jungle instead of https://u.gg/lol/champions/zyra which defaults to Support. You'll just need to create an associative map of your logged positions (LCU's?) versus u.gg's values for the positions (bottom @ LRM vs adc @ u.gg).

There's also an ARAM URL: https://u.gg/lol/champions/zyra/build/?role=jungle&queueType=normal_aram which can get region specific but you get the idea.

This way you can get FILL runes and any other locked in position (or any position you choose from the download dropdown you have) for ideal runes and item sets since I assume you're scraping the item sets and runes based off a set URL which seems to be u.gg/lol/champions/CHAMPNAME and that's a great start so why not spruce it up with u.gg/lol/champions/CHAMPNAME/build/?role=LANENAME to flesh it out? Not sure what other info your LCU provides you: Queue type? Region? There's variables for those on u.gg as well.

Sorry if any of this comes across as insulting this app is just really exciting to me and the potential is huge.

I'm a professional in IT and do coding in web languages but I can help with concepts since I understand the data structures and logic. Not saying I can do what you do, that's software, but I've got ideas I hope are helpful! :)

P.S. I understand Spanish but I'm terrible at speaking it.

[pipe01]

Hi, gracias por tus comentarios. U.gg has an internal API that serves the data as a "minified" JSON (I found this out through the RuneBook implementation), so I don't have to do any HTML scraping. The data I download has data for each position, so it should already be setting pages depending on your position. El jue., 29 nov. 2018 7:11, Gregory Adam Conroy <[email protected]> escribió:

…

Hi Felipe! Mucho gusto. u.gg Integration works great for default roles! Gonna make some assumptions and suggest ideas for how to improve it. Assuming you get the current role from the League Client, you can use that and query u.gg with a specific URL. Example: Zyra locks in as Jungle and you query https://u.gg/lol/champions/zyra/build/?role=jungle instead of https://u.gg/lol/champions/zyra which defaults to Support. You'll just need to create an associative map of your logged positions (LCU's?) versus u.gg's values for the positions (bottom @ LRM vs adc @ u.gg). There's also an ARAM URL: https://u.gg/lol/champions/zyra/build/?role=jungle&queueType=normal_aram which can get region specific but you get the idea. This way you can get FILL runes and any other locked in position (or any position you choose from the download dropdown you have) for ideal runes and item sets since I *assume* you're scraping the item sets and runes based off a set URL which seems to be u.gg/lol/champions/CHAMPNAME and that's a great start so why not spruce it up with u.gg/lol/champions/CHAMPNAME/build/?role=LANENAME to flesh it out? Not sure what other info your LCU provides you: Queue type? Region? There's variables for those on u.gg as well. Sorry if any of this comes across as insulting this app is just really exciting to me and the potential is huge. I'm a professional in IT and do coding in web languages but I can help with concepts since I understand the data structures and logic. Not saying I can do what you do, that's software, but I've got ideas I hope are helpful! :) P.S. I understand Spanish but I'm terrible at speaking it. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADtKiW-axYAi6TBbGHhzEpUVx8fqMZgIks5uz3qNgaJpZM4Y5Ah9> .

[sudravirodhin]

Ahhh, my mistake then. And the API has ARAM runes as well I imagine? All good then. Great stuff! Loved it last night.

[pipe01]

I think U.GG doesn't have data for ARAM, at least none I can see. I'm glad you liked it!

[sudravirodhin]

I'm seeing that it does have ARAM runes, see here: https://u.gg/lol/champions/zyra/build/?role=jungle&queueType=normal_aram

[pipe01]

I'm not sure if I'll implement runes for ARAM because that would involve adding a new position, whose UI would kind of tricky to update. I'll keep this open in case I ever feel like adding it.

[4madz]

I dont see u.gg in the program, why? how can i fix that

[pipe01]

Make sure you downloaded it from here.

[pipe01]

1.2.0 has been released, so you can download it from the releases page now!

[4madz]

After i downloaded new update i get this error every time:
System.InvalidOperationException. Cannot navigate because there is no entry in the back stack of the journal. Create minidump? You can use this to report this issue to me.

[pipe01]

Did you create the minidump? If not, I'm afraid there's not much I can do about it. Try downloading and installing it fresh. El dom., 9 dic. 2018 20:13, 4madz <[email protected]> escribió:

…

After i downloaded new update i get this error every time: System.InvalidOperationException. Cannot navigate because there is no entry in the back stack of the journal. Create minidump? You can use this to report this issue to me. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADtKiVU8pFAdmd3RnUD77HrHyXRs4SpCks5u3WDOgaJpZM4Y5Ah9> .