Ruthless/get tests running #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattieruth
commented
Sep 19, 2024
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() | ||
| # import asyncio |
There was a problem hiding this comment.
this one was so broken because the core types its testing have been replaced, that it was just easier to comment it out.
|
^ Look at that! All checks have passed 😉 |
mattieruth
force-pushed
the
ruthless/get-tests-running
branch
2 times, most recently
from
74005fb to
56a8429
Compare
aconchillo
approved these changes
Sep 19, 2024
|
We probably want to squash all these commits when merging. |
mattieruth
force-pushed
the
ruthless/get-tests-running
branch
from
56a8429 to
bc94a8a
Compare
disable broken tests for now
mattieruth
force-pushed
the
ruthless/get-tests-running
branch
from
bc94a8a to
50b45ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to simply get the tests running and past the collection step. Most of the tests are out of date and broken. This PR does not attempt to fix them, it simply disables them all with a big TODO. Hopefully in separate PRs we can chip away at getting them running again.