Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add control frames for LLM config params" #489

Closed
wants to merge 1 commit into from
Closed

Revert "Add control frames for LLM config params" #489

wants to merge 1 commit into from

Conversation

markbackman
Copy link
Contributor

@markbackman markbackman commented Sep 21, 2024 •
edited
Loading

Reverts #487

Vacation mode is already wreaking havoc. Apologies for the noise. I need to rebase this on main before merging. I forgot this was built form another branch, not main.

@markbackman markbackman requested a review from kwindla September 21, 2024 22:39
@markbackman markbackman self-assigned this Sep 21, 2024
@markbackman markbackman removed the request for review from kwindla September 21, 2024 22:57
@markbackman
Copy link
Contributor Author

Just going to create a new PR to fix this one.

@markbackman markbackman removed their assignment Sep 22, 2024
@aconchillo aconchillo deleted the revert-487-mb/llm-rtvi-service-option branch October 23, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@markbackman