Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Percy checks to PR checks #85

Closed
4 tasks
pixelastic opened this issue Oct 20, 2020 · 1 comment
Closed
4 tasks

Add Percy checks to PR checks #85

pixelastic opened this issue Oct 20, 2020 · 1 comment
Labels

Comments

@pixelastic
Copy link
Owner

pixelastic commented Oct 20, 2020

Whenever I create a new website with norska, it should add a new check on renovate PRs that compare the new website homepage with the previous one.

This will allow automatic updates that won't break the website.

Because Percy checks are made remotely, I shouldn't need to enable deploy previews for Netlify. It should a be able to send the page to be tested at Percy and run the checks there.

  • Think if this is a norska feature or an aberlaas one
  • Where to store the Percy account identity?
  • The default page to be tested should be the homepage, but could be configured to target a specific test page
  • Should only apply to PRs made by renovate
@pixelastic pixelastic changed the title Integrate Percy checks Add Percy checks to PR checks Apr 16, 2021
@pixelastic
Copy link
Owner Author

I'm dropping this in favor of #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant