New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: pkgcheck does not verify make.defaults quoting requirement #692

Open

1 task done

Jannik2099 opened this issue Jul 7, 2024 · 0 comments

Open

1 task done

[Bug]: pkgcheck does not verify make.defaults quoting requirement #692

Jannik2099 opened this issue Jul 7, 2024 · 0 comments

Labels

bug

Jannik2099 commented Jul 7, 2024

Is there an existing issue for this?

I have searched the existing issues

Current Behavior

see https://bugs.gentoo.org/935685

make.defaults syntax is defined in PMS 5.2.4:

The file itself is a line-based key-value format. Each line contains a single VAR="value" entry, where the value must be double quoted.

pkgcheck does not seem to warn on unquoted VAR=value lines, as have been present for a while e.g. in https://github.com/gentoo/gentoo/blob/595c607772111487ab160081434422a98118e566/profiles/features/llvm/make.defaults#L34

Expected Behavior

No response

pkgcheck version

pkgcheck 0.10.30

pkgcore version

pkgcore 0.12.27

Jannik2099 added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment