Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store private key in keychain #2

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Store private key in keychain #2

merged 3 commits into from
Nov 26, 2024

Conversation

mxcl
Copy link
Member

@mxcl mxcl commented Nov 26, 2024

We store it so it can only be accessed by our developer ID.

Please vet the code since I am a rust n00b etc.

@mxcl mxcl requested a review from jhheider November 26, 2024 17:43
We store it so it can only be accessed by our developer ID.
Copy link

@jhheider jhheider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes and CI added in 90ebbc3. I'll rebase #1 onto this.

@mxcl mxcl marked this pull request as ready for review November 26, 2024 20:05
@mxcl mxcl merged commit 35251bb into main Nov 26, 2024
5 checks passed
@mxcl mxcl deleted the keychain branch November 26, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants