Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicit import map for Deno 2 #6

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

GauBen
Copy link
Contributor

@GauBen GauBen commented Nov 22, 2024

  • HTTP import maps were removed in Deno 2
  • --unstable flag was removed in Deno 2

@jhheider
Copy link
Contributor

jhheider commented Nov 22, 2024

thanks, @GauBen. I pulled in the current pkgx~1.3 deno.jsonc imports block.

edit: doh. i think the monkey-patched version was what we needed. thanks for the hard work.

@jhheider jhheider merged commit 3bfd4b1 into pkgxdev:main Nov 22, 2024
jhheider added a commit that referenced this pull request Nov 22, 2024
* fix: explicit import map for Deno 2

* fix: removed --unstable flag

* use current deno.jsonc imports

---------

Co-authored-by: Jacob Heider <[email protected]>
@GauBen
Copy link
Contributor Author

GauBen commented Nov 22, 2024

@jhheider I tried that too but bump.ts would need a large refacto to support new APIs 😂

@jhheider
Copy link
Contributor

yep. and there's no need to force it forward (unless it needs fixes). 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants