-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add customization support for FieldBaseAutosuggest options #10624
Comments
…seAutosuggest API" This reverts commit b23bbdc.
…d value is true
pkp/pkp-lib#10624 Add ROR and NewTab icons pkp/pkp-lib#10624 Update Autosuggest component pkp/pkp-lib#10624 Apply changes from icon component pkp/pkp-lib#10624 Remove FieldCombobox component pkp/pkp-lib#10624 Remove autosuggest props in api pkp/pkp-lib#10624 Move methods from FieldBaseAutosuggest to useAutosuggest API Revert "pkp/pkp-lib#10624 Move methods from FieldBaseAutosuggest to useAutosuggest API" This reverts commit b23bbdc. pkp/pkp-lib#10624 Move autosuggest functions from api to component pkp/pkp-lib#10624 Add ROR autosuggest component pkp/pkp-lib#10624 Add isMultiple prop to Autosuggest component pkp/pkp-lib#10624 Remove inputName and deselectLabel props pkp/pkp-lib#10624 Simplify data handling from fetch api for ror autosuggest component pkp/pkp-lib#10624 Use mock data for ror autosuggest story pkp/pkp-lib#10624 Remove custom options story in FieldBaseAutosuggest component pkp/pkp-lib#10624 Render Autosuggest component even if prop isDisabled value is true pkp/pkp-lib#10624 Reduce input props for the autosuggest component
pkp/pkp-lib#10624 Add ROR and NewTab icons pkp/pkp-lib#10624 Update Autosuggest component pkp/pkp-lib#10624 Apply changes from icon component pkp/pkp-lib#10624 Remove FieldCombobox component pkp/pkp-lib#10624 Remove autosuggest props in api pkp/pkp-lib#10624 Move methods from FieldBaseAutosuggest to useAutosuggest API Revert "pkp/pkp-lib#10624 Move methods from FieldBaseAutosuggest to useAutosuggest API" This reverts commit b23bbdc. pkp/pkp-lib#10624 Move autosuggest functions from api to component pkp/pkp-lib#10624 Add ROR autosuggest component pkp/pkp-lib#10624 Add isMultiple prop to Autosuggest component pkp/pkp-lib#10624 Remove inputName and deselectLabel props pkp/pkp-lib#10624 Simplify data handling from fetch api for ror autosuggest component pkp/pkp-lib#10624 Use mock data for ror autosuggest story pkp/pkp-lib#10624 Remove custom options story in FieldBaseAutosuggest component pkp/pkp-lib#10624 Render Autosuggest component even if prop isDisabled value is true pkp/pkp-lib#10624 Reduce input props for the autosuggest component
* pkp/pkp-lib#10624 Move css class rules to Autosuggest component * pkp/pkp-lib#10624 Rename NewTab icon component to OpenNewTab * pkp/pkp-lib#10624 Fix inline-alignment on the Autosuggest input component * pkp/pkp-lib#10624 Remove empty useAutosuggest composeable api
@blesildaramirez how can I test this? I tried adding contributor and not seeing the auto suggest feature locally. |
Hello @blesildaramirez I gave it a look. It isn't clear what I can check exactly but I tried out submission keywords and it had auto populated content. Also if I added a keyword in one it would autosuggest in another. Are there other locations I should test for this autosuggest? However affiliations didn't seem to work when adding them while creating a new submission (adding contributor)? |
Hello @blesildaramirez / @jardakotesovec thanks for the components FieldBaseAutosuggest and FieldRorAutosuggest. I also saw that you added the ROR icon, I removed mine and using yours. Are you sure that this is as @Devika008 intended for adding custom affiliations? What I understood with the video she created was that this should be similar as adding the ROR affiliations:
I miss selecting the custom affiliation in the drop down. This should be there, even if the affiliation is found or not in the ROR database. I have already implemented a lookup with plain html/css. Below you can see a screen recording of how this is working now. |
Hi @GaziYucel , thanks for pointing out the missing ability to allow custom affiliation names. I just updated the main branch from ui-library to be able to use it. Just a few confirmations on this:
Thanks, and let me know if you have any questions on this. |
Hi @Tribunal33 , thanks for testing this!
Let me know if you have any questions regarding this. Thanks! |
Hi @blesildaramirez, thank you for your quick reply/actions. I assumed that I was going to make further changes to the new FieldRorAutosuggest component to fit my needs, that's why I didn't write more in depth above. Now with your questions I realize that there is some misunderstanding regarding the internal workings. I have written some more depth and just added it here #7135 (comment), because I think that's a better place for this information. I am not sure how to translate all this to your work, AutoSuggest and to decide what and who does what next. But I think it's important to understand what is happening. I am afraid we do work which we will throw away later.
|
It seems you cleared it all and everything is clear now? |
Hi @bozana , yes - for the questions I have above. I'm waiting on the new updates on the API that @GaziYucel had worked on and integrate with the UI. Thanks for checking! |
Hi @blesildaramirez. I found the bug in the import of the datadump of ror.org. Apparently, there are columns added to the csv file, which changed the mapping. I changed the php code, so that the column names are dynamically mapped to our OJS naming. The imports should be correct now. |
…ject to Autosuggest component
…ject to Autosuggest component (#481)
Closing this issue, the proper implementation will be handled on the main issue: #7135 |
Issue Description
The
FieldBaseAutosuggest
component needs to support customization of dropdown options to align with new designs for selecting affiliations when adding contributors. This includes adding icons and other elements to improve usability and meet design requirements.Action
Improve the
FieldBaseAutosuggest
component to allow customization of each dropdown option. This includes ability to add icons, links, or other elements by using namedslots
. Ensure the component retains its default rendering behavior for cases where customization is not required.Mockup
Pull request:
pkp/ui-library#449(closed)pkp/ui-library#458
Test only (OJS):
pkp/ojs#4541
The text was updated successfully, but these errors were encountered: