Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Issues link below all the displayed "Dashboards" for users with multiple roles #11070

Closed
blesildaramirez opened this issue Mar 12, 2025 · 2 comments
Closed

Move Issues link below all the displayed "Dashboards" for users with multiple roles #11070

blesildaramirez opened this issue Mar 12, 2025 · 2 comments
Assignees
@blesildaramirez
Labels
Accessibility Any issue that impacts assistive technology or users with visual or physical impairments.
Milestone
3.5.0 LTS

Comments

@blesildaramirez
Copy link
Contributor

blesildaramirez commented Mar 12, 2025 •
edited
Loading

Issue Description

When a user has multiple roles, more than one "Dashboards" menu is displayed. (see screenshot below for example)
The Issues link should be below all of the submission dashboards available for the user.

Image

How to reproduce / Current behavior

Login as a user with reviewer, author, and journal editor roles. Multiple submission dashboards should appear on the sidemenu.

What application are you using?

OJS 3.5.0

Testing method

  • Manual

Action

Move the Issues link below the last Submissions dashboard link: (e.g from the screenshot: "My Submissions")

Pull requests:
OJS
stable-3_5_0: pkp/ojs#4733
main: pkp/ojs#4734
@blesildaramirez blesildaramirez added the Accessibility Any issue that impacts assistive technology or users with visual or physical impairments. label Mar 12, 2025
@blesildaramirez blesildaramirez self-assigned this Mar 12, 2025
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Mar 12, 2025
@blesildaramirez
pkp/pkp-lib#11070 Move Issues link after the last Submissions dashboa…
14c59f4 
…rd menu link in the sidemenu
@blesildaramirez blesildaramirez changed the title Move Issues link below all the displayed "Dashboard" for users with multiple roles Move Issues link below all the displayed "Dashboards" for users with multiple roles Mar 12, 2025
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Mar 12, 2025
@blesildaramirez
pkp/pkp-lib#11070 Move Issues link below all the displayed Dashboards…
36bf0d9 
… for users with multiple roles
@blesildaramirez blesildaramirez added this to the 3.5.0 LTS milestone Mar 12, 2025
@asmecher
Copy link
Member

Added a review here, thanks!

blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Mar 12, 2025
@blesildaramirez
pkp/pkp-lib#11070 Move Issues link below all the displayed Dashboards…
e14374f 
… for users with multiple roles
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Mar 12, 2025
@blesildaramirez
pkp/pkp-lib#11070 Use strict comparison for array_search results to a…
b4df408 
…void incorrect falsy values
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Mar 12, 2025
@blesildaramirez
pkp/pkp-lib#11070 Move Issues link after the last Submissions dashboa…
64f94de 
…rd menu link in the sidemenu
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Mar 12, 2025
@blesildaramirez
pkp/pkp-lib#11070 Use strict comparison for array_search results to a…
dd4f7ea 
…void incorrect falsy values
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Mar 12, 2025
@blesildaramirez
pkp/pkp-lib#11070 Remove enable_new_submission_listing config check w…
b686ca2 
…hen setting Issues link
blesildaramirez added a commit to blesildaramirez/ojs that referenced this issue Mar 12, 2025
@blesildaramirez
pkp/pkp-lib#11070 Remove enable_new_submission_listing config check w…
40e446e 
…hen setting Issues link
@asmecher
Copy link
Member

I approved both PRs, thanks, @blesildaramirez!

blesildaramirez added a commit to pkp/ojs that referenced this issue Mar 12, 2025
@blesildaramirez
Merge pull request #4734 from blesildaramirez/i11070
c2eef66 
pkp/pkp-lib#11070 [main] Move Issues link below all the displayed "Dashboards" for users with multiple roles
asmecher pushed a commit to pkp/ojs that referenced this issue Mar 12, 2025
@blesildaramirez @asmecher
pkp/pkp-lib#11070 Move Issues link after the last Submissions dashboa…
ed053a2 
…rd menu link in the sidemenu
asmecher pushed a commit to pkp/ojs that referenced this issue Mar 12, 2025
@blesildaramirez @asmecher
pkp/pkp-lib#11070 Use strict comparison for array_search results to a…
355a30f 
…void incorrect falsy values
asmecher pushed a commit to pkp/ojs that referenced this issue Mar 12, 2025
@blesildaramirez @asmecher
pkp/pkp-lib#11070 Remove enable_new_submission_listing config check w…
342222c 
…hen setting Issues link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blesildaramirez blesildaramirez

Labels
Accessibility Any issue that impacts assistive technology or users with visual or physical impairments.
Projects
None yet
Milestone
3.5.0 LTS
Development

No branches or pull requests
2 participants
@asmecher @blesildaramirez