Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete our custom add_workspace_toml_entry logic in create subcommand #144

Open
pksunkara opened this issue Dec 30, 2023 · 2 comments
Open

Comments

@pksunkara
Copy link
Owner

MSRV needed 1.75.0

rust-lang/cargo#12779

@filleduchaos
Copy link

Yeah this breaks cargo ws create - the package creation itself succeeds, but because the output from Cargo does not contain "Created" cargo workspaces assumes it failed

Std output of cargo new in a workspace (on nightly 2024-03-02):

    Creating library `foo` package
      Adding `foo` as member of workspace at `/some/path/to/workspace`

@sushruth
Copy link
Contributor

I opened a PR for it potentially fixing this - #152

@pksunkara pksunkara changed the title Investigate how cargo new collides with cargo ws new Delete our custom add_workspace_toml_entry logic in create subcommand Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants