-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Vulkan pipeline #654
Conversation
Missing conversion patterns have to be added directly to the upstream GPU to SPIRV conversion pass as this conversion cannot be split into multiple steps. This addition could be upstreamed later if it works well. The SPIRV attribute adding passes are taken from IMEX and slightly adapted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick review of the source, will look at tests later
e5ab906
to
1909302
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, this has too much Vulkan specific logic for my comfort and we should look into upstreaming all of it, but for now, it should be fine. We really need to move to something like OpenCL soon.
Expands Vulkan lowering pipeline with extra support passes to allow executing more linalg ops using Vulkan backend.
Changes: