Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bench - print more data types #712

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

adam-smnk
Copy link
Collaborator

Expands tpp-run '-print' utility to support more data types.

@rengolin
Copy link
Contributor

How does this relate to #555? Could we fix these two birds?

Expands tpp-run '-print' utility to support more data types.
@adam-smnk
Copy link
Collaborator Author

How does this relate to #555? Could we fix these two birds?

vector.print is more flexible. Its lowering infrastructure can generate call for greater range of data types compared to what is available in explicit printMemref* runner utils.

W.r.t. #555, it doesn't cover my needs as I want to use and print standard f16 and currently printMemrefF16 is also unavailable.
Overall, I'd rather see a dedicated memref.print op.

@adam-smnk adam-smnk merged commit 5122399 into plaidml:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants