Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate fill operations when the use is a contraction and we can fold the fill in the contraction later on in the pipeline using:
fold-xsmm-flags
. Duplication avoids introducingmemref.copies
by bufferization. Example,Without this PR it bufferizes as:
With this PR the IR looks like:
The PR has minor performance impact, the only notable improvement is for
fp32_mha_tensorflow_seq_len_32
. The IR looks cleaner too with 1 less allocation and all the beta flags properly folded.fp32_mha_tensorflow_seq_len_1024
does not improve because dimensionality allows fusion to distribute the fill, see: b1167fe.This PR is part of #783