Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow setting mysqld-exporter resources #311

Closed
gairadzi opened this issue Sep 11, 2022 · 3 comments · Fixed by #642
Closed

[Feature Request] Allow setting mysqld-exporter resources #311

gairadzi opened this issue Sep 11, 2022 · 3 comments · Fixed by #642

Comments

@gairadzi
Copy link

The resources for the mysqld-exporter container are currently hard-coded in the operator, we would like to able to change them in the shard template resource.

@subnix
Copy link
Contributor

subnix commented Mar 4, 2024

Looks like closed in #494

@GenLN
Copy link

GenLN commented Sep 24, 2024

Hi @subnix
I think something isn't working as expected. Even if I don't define limit on CPU it will assign CPU limit to 100m. As we have defined resources like

mysqldExporter:
  resources:
    limits:
      memory: 125Mi
    requests:
      cpu: 100m
      memory: 50Mi

but looking in pod definition

  resources:
    limits:
      cpu: 100m
      memory: 125Mi
    requests:
      cpu: 100m
      memory: 50Mi

@frouioui
Copy link
Member

frouioui commented Dec 2, 2024

Hi! @GenLN, this is correct, I have proposed a fix for this issue: #642, once that is merged we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants