-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: VTTablet naming #543
Comments
I'm not necessarily against the idea, but it's worth noting that labels are the standard way to do this and it allows for using label selectors for filtering. For example:
That is objectively much better than having to use e.g. awk with the list of pod names. I understand that's not as convenient as being able to quickly see it in the pod names with a simple |
Mainly reason is for easy monitoring/alerting components. As for vttablets I do monitor each pod on it's metric exposed ports... But for pod/container resource usage is much harder to obtain these labels in metrics(offers pod name or pvc name). Which if it was there would make dashboarding and filtering much easier, also alerting. If I can filter it by keyspace, shard, would show much more meaning info than pod name of the vttablet. |
The problem you describe in the comment above certainly seems valid to me, but it's also not what I see the issue title and description as being about -- not as I read it anyway. IMO it's better to open an issue that describes the problem you're having in detail rather than proposing a potential solution which you feel might make 1 or more problems better. Make sense? Issue is the problem, a PR would be a proposed solution to the given problem. |
@frouioui yes, we managed to solve it via monitoring and custom grafana dashboards to easily identify tablets from which keyspace, shard, is it primary or not, etc. |
Hi, is there some option to define custom naming of vttablet pods?
VTTablet pods are named like:
clusterName-vttablet-cellName-Tablet_UID-randomString
I would like to include keyspace-shard into naming instead having them on labels...
clusterName-vttablet-cellName-Keyspace-Shard-Tablet_uid-random string
Or if this gets too long for naming it like:
vttablet-Keyspace-Shard-TabletUID-randomString
cell in labels, clusterName in labels...
Or adjust values file to have an option for custom naming pods of vttablets and other components...
Looking at the pods list of vttablets i have no idea which one is for the specific keyspace/shard, until i read labels of the pod...
The text was updated successfully, but these errors were encountered: