You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
due to changes earlier this year, method add_handler of class HandlerRegistry silently ignores parameter authenticators if Tuple[Authenticator] is provided, resulting in authenticators being []. This is an issue especially when the value for this field comes from default value of another method, since lists (as mutable types) are discouraged and tuples are preferred in default values.
I'd expect either an error raised when unexpected type is received, and/or preferably to accept also tuples or iterables in general.
The text was updated successfully, but these errors were encountered:
martinHrabina
changed the title
HandlerRegistry.add_handler; authenticators
HandlerRegistry.add_handler method ignores tuples in authenticators parameter
Dec 5, 2024
Hello everybody,
due to changes earlier this year, method
add_handler
of classHandlerRegistry
silently ignores parameterauthenticators
ifTuple[Authenticator]
is provided, resulting in authenticators being []. This is an issue especially when the value for this field comes from default value of another method, since lists (as mutable types) are discouraged and tuples are preferred in default values.I'd expect either an error raised when unexpected type is received, and/or preferably to accept also tuples or iterables in general.
The text was updated successfully, but these errors were encountered: