Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HandlerRegistry.add_handler method ignores tuples in authenticators parameter #320

Open
martinHrabina opened this issue Dec 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@martinHrabina
Copy link

Hello everybody,

due to changes earlier this year, method add_handler of class HandlerRegistry silently ignores parameter authenticators if Tuple[Authenticator] is provided, resulting in authenticators being []. This is an issue especially when the value for this field comes from default value of another method, since lists (as mutable types) are discouraged and tuples are preferred in default values.

I'd expect either an error raised when unexpected type is received, and/or preferably to accept also tuples or iterables in general.

@martinHrabina martinHrabina changed the title HandlerRegistry.add_handler; authenticators HandlerRegistry.add_handler method ignores tuples in authenticators parameter Dec 5, 2024
@airstandley airstandley added the bug Something isn't working label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants