You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is more a topic for discussion/consideration than it is a bug report.
I'm using these flashes on a new project. Rather than generating a separate stylesheet for the flashes alone, I turned flashes.scss into a partial that gets imported into my main stylesheet. When I did this, a number of pre-existing mixins were overwritten. In my case, the mix-ins were defined by Compass, but it's not too hard to imagine conflicts with hand-written mix-ins.
It's simple enough to work around, with a few different options:
Just keep flashes in their own stylesheet
Play with the import order so the flashes get imported first then import the conflicting mixins.
edit the scss to rename the mixins with a namespace prefix
I didn't bother testing #2, but it sounds like it should work. In my case, I just "namespaced" the mixins by prepending "flashes-" to the front. Do you think this is worth considering as a default?
The text was updated successfully, but these errors were encountered:
Indeed namespacing w/prefixes would solve this issues. I am working on turning this into a gem, which will be using our own Bourbon as a dependency for the mixins.
I have heard reports of variable conflicts as well—I will likely address this issues in the coming days.
This is more a topic for discussion/consideration than it is a bug report.
I'm using these flashes on a new project. Rather than generating a separate stylesheet for the flashes alone, I turned flashes.scss into a partial that gets imported into my main stylesheet. When I did this, a number of pre-existing mixins were overwritten. In my case, the mix-ins were defined by Compass, but it's not too hard to imagine conflicts with hand-written mix-ins.
It's simple enough to work around, with a few different options:
I didn't bother testing #2, but it sounds like it should work. In my case, I just "namespaced" the mixins by prepending "flashes-" to the front. Do you think this is worth considering as a default?
The text was updated successfully, but these errors were encountered: