Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup heroku review apps #34

Open
blackjid opened this issue Feb 12, 2016 · 4 comments
Open

Setup heroku review apps #34

blackjid opened this issue Feb 12, 2016 · 4 comments
Assignees
Labels
devops Devops Guild wait

Comments

@blackjid
Copy link
Member

No description provided.

@blackjid blackjid modified the milestone: 2.1 Mar 22, 2016
@blackjid blackjid removed this from the 2.1 milestone May 6, 2016
@rjherrera rjherrera self-assigned this Apr 12, 2019
@rjherrera
Copy link
Member

There is a Heroku CLI command to enable review apps:

heroku reviewapps:enable -p <pipeline-name> --app <parent-app>

However, it doesn't address the creation of the app.json file with the specifications for it. There is no automated way of generating that file (CLI or API), but Heroku has a dashboard tool to do so, so it seems that they already do the hard work.

I contacted Heroku asking whether there are any plans of making an API call/CLI command for this matter. If not, we could create the app.json file in the review apps recipe, or leave that to the manual setup of new projects.

I'll update this issue if I get any new information.

@rjherrera rjherrera added the wait label Jan 29, 2020
@hidalgoegz
Copy link
Contributor

@rjherrera Is there an update for this? Is this still needed?

@blackjid
Copy link
Member Author

image
🤣

@rjherrera
Copy link
Member

@hidalgoegz Sadly the CLI remains the same, so only useful for enabling review apps, but not for generating the app.json 😞 . I haven't heard back from them, so I'd keep the wait label until I do. I think i will ping them again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Devops Guild wait
Development

No branches or pull requests

3 participants