Add initial support for 3D Gaussian Splatting #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Will Eastcott <[email protected]>
Co-authored-by: Will Eastcott <[email protected]>
mvaligursky
reviewed
Oct 13, 2023
| const zMinMax = minmax(z); | ||
|
|
||
| const aabb = new BoundingBox(); | ||
| aabb.setMinMax(new Vec3(xMinMax[0], yMinMax[0], zMinMax[0]), new Vec3(xMinMax[1], yMinMax[1], zMinMax[1])); |
There was a problem hiding this comment.
you could probably just use Bounds.computeMinMax
mvaligursky
approved these changes
Oct 13, 2023
willeastcott
changed the title
|
I added a slightly hacky camera focal point calculatoin so zooming the camera in takes you to the center of interest. |
|
Please list references used to create this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for rendering Guassian Splats in the model-viewer.
The bicycle scene in model-viewer:
This PR adds the following
Limitations
Next Steps
References