Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the latest v2.0.0-rc4 ? #121

Open
jimmyliangacn opened this issue May 28, 2024 · 10 comments
Open

Is the latest v2.0.0-rc4 ? #121

jimmyliangacn opened this issue May 28, 2024 · 10 comments

Comments

@jimmyliangacn
Copy link

Looking through the feature branches that may be the latest but yet pulled into main. Can the project maintainers merge this to main and cut a release please? Latest release is 1.0.0 in 2021.

Perhaps @itewk @twling can help?
CC: @HunterGerlach and @bcarr-redhat as you made the latest commit to 2.0.0-rc4

@dwinchell
Copy link
Contributor

Hi @jimmyliangacn. Do you mean feature branches that have not been pulled into main?

To my knowledge, none of those unmerged feature branches are finished, as in not functional and passing tests. That's why they were never merged. I know for sure that's the case with feature/cypress. Perhaps we should have deleted them to avoid confusion.

To be honest this project is not very actively maintained anymore, though you may get some responses or offers to help. If you're passionate about continuing it, as long as the other maintainers agree, I'd be okay giving you maintainer access if you want it.

@jimmyliangacn
Copy link
Author

My apologies - I was talking about feature/2.0.0rc4 (I had it in the title, but not the description/body).

I have worked with Ben before so I can ask him to see if he could wrap up his work on his branch and create the PR.

For the project I am supporting we are using Ploigos. Once I get a project GitHub setup then I think we can look into having maintainer access established.

@itewk
Copy link
Contributor

itewk commented May 28, 2024

@jimmyliangacn happy to help. but unclear what being asked. can you link to what you are looking to be merged?

@jimmyliangacn
Copy link
Author

I'd like to see if @bcarr-redhat (or someone) can merge feature/2.0.0rc4 into main. I don't want to speak for Ben here but if we don't hear back from him then I suppose I can take the initiative and create the PR in his behalf.

@bcarr-rh
Copy link

I'll take a look!

@bcarr-rh
Copy link

PLOIGOS_SOURCE

I believe this arg is set elsewhere and 1.0.0 is the default value. I thank that is the only change in the branch. Everything else was already merged into main from 537762d

@bcarr-rh
Copy link

do we want to cut a release for https://github.com/ploigos/ploigos-containers/tree/v2.0.0-rc4 ? @itewk @dwinchell

@itewk
Copy link
Contributor

itewk commented May 29, 2024

do we want to cut a release for https://github.com/ploigos/ploigos-containers/tree/v2.0.0-rc4 ? @itewk @dwinchell

@bcarr-rh do it.

@jimmyliangacn
Copy link
Author

Thanks @bcarr-rh. Just wondering - should the release be something like 2.0.0 or 2.0.1 instead of -rc4 which I think stands for "release candidate #4"?

@itewk
Copy link
Contributor

itewk commented May 30, 2024

@bcarr-rh and @jimmyliangacn , yes, it shoudl be released as v2.0.0. you may also want to update the cli tools version to something newer...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants