Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create seperate github action workflow for pull requests #43

Open
itewk opened this issue Dec 2, 2020 · 0 comments
Open

create seperate github action workflow for pull requests #43

itewk opened this issue Dec 2, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@itewk
Copy link
Contributor

itewk commented Dec 2, 2020

purpose

currently the same github action workflow is used for publishing and pull requests.

history

This was done to "make life easy" for images that are dependent on eachother so they can pull their dependent image from quay even for a PR.

issues

  • all pull requests have to be from branches on this repo since they require secrets that allow the publish to publish to quay.io

fix

create a new github workflow for pull reuquests that only uses local images (possibly having to pass them to/from depdent jobs) and doesn't do any publishing to quay.io thus allowing pull requests from forked repositories

@itewk itewk added the enhancement New feature or request label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant