New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert shell commands that call oc into k8s module tasks #117

Open

dwinchell opened this issue Jan 14, 2021 · 0 comments

Labels

good first issue

Collaborator

dwinchell commented Jan 14, 2021 •

edited

Loading

Stop doing this:

name: Clean up remaining resources
shell: |
oc delete -n {{ tssc_namespace }} KeycloakUser,KeycloakClient --all

Do it like this:

name: Clean up remaining resources
k8s:
figure: this
stuff: out

Why?

The shell commands that run during the finalizer fail when things are missing, which causes the finalizer to fail, which results in other resources not being cleaned up
We use the k8s module for most changes to ocp resources and want to be consistent

dwinchell added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment