Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: monorepo support #132

Open
christophermay07 opened this issue Apr 26, 2021 · 3 comments
Open

Documentation: monorepo support #132

christophermay07 opened this issue Apr 26, 2021 · 3 comments
Assignees

Comments

@christophermay07
Copy link
Contributor

Creating a separate issue from #99 to deal with monorepo (vs. one build resulting in multiple artifacts).

Assume a git repo with the following layout:

monorepo_base/
    - .git/
    - app1/
    - app2/
    - ...
    - appN/

PSR should provide the ability for a user to specify a subdirectory from the repository root (e.g, app1/) to begin the build from.

@christophermay07 christophermay07 self-assigned this Apr 26, 2021
@itewk
Copy link
Contributor

itewk commented Apr 26, 2021

I believe this already works. What doesn’t work is if you are doing maven with a parent Pom that builds multiple artifacts or if you want to build multiple containers at the same time in one workflow. My guess is this issue will turn into a “better document the process” unless you meant one of those other use cases.

@christophermay07
Copy link
Contributor Author

I believe this already works. What doesn’t work is if you are doing maven with a parent Pom that builds multiple artifacts or if you want to build multiple containers at the same time in one workflow. My guess is this issue will turn into a “better document the process” unless you meant one of those other use cases.

That's great news! I'll happily take on updating the documentation -- I just need to play around with PSR a bit more this week to understand how monorepo support works.

@christophermay07 christophermay07 changed the title Monorepo support Documentation: monorepo support Apr 26, 2021
@itewk
Copy link
Contributor

itewk commented Apr 26, 2021

@christophermay07 you firs thave to define what yu mean by "mono-repo"

  1. a single source repo that contains multiple applications that are independently built, put into containers, and deployed in seperate release engineering workflows OR
  2. a single source repo that contains multiple applciaitons that all go into their own containers but need to be built/tested/deployed all in one release engineering workflow OR
  3. a single source repo that contains multiple applictions (zips/wars/ears/etc) that all get built togeather or indepently but ultimatlly end up inside the same container

the first use case I beleive there isn't any issue doing with the current PSR as there is ways to specify paths for everything.

The other two use cases is where we would need technical work tos upport.

minimally as part of this item maybe you should create a PR against the ploigos-docs to define mono-repo and define if it covers all three of those uses cases, or only 1 adn the other use cases get other pithy names....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants