Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven-no-transfer-progress is not being used when updating pom version - breaking workflows with untrusted maven repo #177

Open
itewk opened this issue Aug 2, 2021 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@itewk
Copy link
Contributor

itewk commented Aug 2, 2021

issue

when calilng run_maven in the MavenDeploy class to update the version the maven-no-transfer-progress config value is not being checked or added to the flags.

backround

It was assumed that updating the verison was a local only operation and it wouldn't be a problem. turns out it is

fix

need to copy or abstract the logic form MavenGeniric::_run_maven_step to the MavenDeploy when doing the version update

@itewk itewk added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Aug 2, 2021
@itewk
Copy link
Contributor Author

itewk commented Aug 2, 2021

@sroth1 fyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant